Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): always enable continue button on FileUpload and DrawBoundary upload page #3137

Merged
merged 1 commit into from
May 10, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented May 10, 2024

We currently have three components that don't enable the "Continue" button by default which is flagged as a bad pattern in the "usability" feedback section of our Accessbility report:

  1. FindProperty (two pages - select & map)
  2. DrawBoundary (two pages - map & upload)
  3. FileUpload

These changes address enabling the continue button for all "upload" instances. I'll continue to address the map & select instances in a followup PR (see #3022).

Testing:

  • DrawBoundary
    • When you switch to the upload page the "continue" button should always be enabled now
    • If you click it before uploading, you should see an error wrapper around the upload preventing you from proceeding
    • If you upload a file, you can proceed successfully
  • FileUpload
    • "Continue" should be enabled by defualt
    • If you click before uploading, or while a large file is still loading, you should see an error wrapper preventing you from proceeding
    • If you upload a file, you can proceed successfully

@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak requested a review from a team May 10, 2024 15:25
Copy link

github-actions bot commented May 10, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both upload instances working great, with appropriate error messaging in place 👍

@jessicamcinchak jessicamcinchak merged commit 32e6278 into main May 10, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/file-uploads-enable-continue branch May 10, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants